How Can We Make PR Reviews More Collaborative and Less Blame-Focused?
Asked by
CuriousCoder42
We've created an automated system that flags stale pull requests (PRs) in our engineering performance board if they haven't been reviewed in over 24 hours. While it has helped reduce the age of the reviews, I'm worried it might lead to a blame culture. What practices or norms could we establish around PR metrics to promote teamwork and assistance instead of finger-pointing? Do things like weekly review buddies or rotating reviewer assignments actually help?
Answers
Iโve found that using shorthand in comments helps a lot! Phrases like "do," "try," "consider," and "nit" allow me to give clear feedback without sounding harsh. It's all about how you frame thingsโbeing clear in your intent can really improve the review experience.
Reply to this answer
Honestly, just asking for reviews during standups or in Slack usually does the trick for me. I'm curious thoughโis the finger-pointing about the reviewer not reviewing promptly or just a lack of reviewers? And isn't 24 hours a tad short? Especially if you have a team spread across different time zones.
Reply to this answer
We use Slack to gently remind everyone about PRs that havenโt been updated in two days, which keeps it casual and avoids blame. Sometimes delays are due to personal circumstances like illness, so itโs more about nudging than pointing fingers.
Reply to this answer
Reviews are crucial for team growth, not just clearing tasks off a list. When metrics start to resemble KPIs, it can create pressure, lowering morale and undermining the learning opportunities. A better way is to emphasize collaboration during reviews, like pairing up teammates and rotating reviewers to spread knowledge. Recognizing good feedback in retrospectives can also help shift perspectives around reviews from being a chore to a valuable opportunity.
Reply to this answer
If the goal is to speed things up, why not have a script auto-approve PRs after two days? Just make sure it runs all the necessary tests first! It could really lower the performance pressure.
Reply to this answer
Add your answer
Answers are reviewed before publication.
Related Discussions