How Long Should Functions Be in Your Code?

It really depends on the function’s purpose. A long function filled with hardcoded data that's easy to read? That's fine. But a shorter one with complex logic doing multiple tasks? That's usually a red flag.

I think the focus should be less on the line count and more on the complexity. For example, having a hundred straightforward statements might be okay, but if it includes a lot of control flow like if statements and loops, it could get complicated even if it's only 20 or 30 lines.

In my experience, a function should ideally be short enough to view without scrolling. But I’m okay with a bit of scrolling if that means keeping a function concise and focused on just a couple of concepts.

Ultimately, a function should encapsulate a single logical concept or mutation. Length is less important than clarity and maintaining a single responsibility.

Absolutely agree! I've seen single lines that are much harder to wrap your head around than something broken down into five clear lines. I tend to avoid writing functions that are 30+ lines, as I find it's usually better to separate out unrelated or repetitive tasks into their own functions.