I've been getting back into learning Python and recently completed a project that's a program for checking if a number is even or odd. I initially made a version that randomly picked a number from a list, but then I realized I needed to accept user input instead. The program now prompts the user for a valid positive integer. It checks if the input is a negative number, too large (over 1 million), or not a number at all, giving the user three chances to enter valid input before quitting. While it's working as intended, I'm curious whether there's a way to optimize the code or if the way I wrote it is considered 'bad'. I don't want to pick up any bad programming habits.
3 Answers
Yeah, reducing the duplication of `attempts += 1` by using a helper function would really simplify things. Plus, if you format your conditions to check the input validity all at once, it'll reduce your if-else nesting, making it easier to read and maintain.
I noticed you have a lot of comments, which is great for learning, but you might want to remove some once you're more confident in your understanding. It can clutter your code a little. Think about grouping your input validation into a single function, which would streamline your main logic!
I totally get that! The comments help me keep things straight right now. As I get more experienced, I'll definitely aim to trim them back.
You can definitely streamline your code a bit! Right now, you're repeating the line to increase the attempts and check the remaining attempts multiple times, which isn't necessary. Maybe consider a function to handle invalid attempts instead of duplicating that logic. It could make your code cleaner and easier to maintain!
That's a great point! Consolidating repetitive code into a function not only makes it cleaner but also easier to debug in the future.
Agreed! A clearer structure would also allow you to easily add more features down the line if needed.