I've been working diligently on a pull request for a well-known open source project. After submitting my PR, a maintainer made some changes to my code that seem to have introduced some serious issues, including console errors and other bugs. The original problem I addressed was completely fixed before those changes. Now I'm sitting here, wondering if it's rude to submit my own review to highlight these problems. I'm worried because I really want my contribution to be merged, but I feel like it's now in a worse state than before. What should I do? Should I address these issues myself and point them out in my review, or should I just stay quiet? I put a lot of effort into this, and I want to see it succeed!
2 Answers
You definitely should address the changes. It's important to communicate about the errors introduced by the maintainer's edits. You could frame it like this: 'Hey, I noticed a few issues that popped up after the recent changes, like errors in lines X, Y, and Z. Could you clarify what those changes were meant to solve?' It's all about keeping the conversation constructive!
You should definitely bring it up! If there are bugs, it's best to address them directly rather than letting it slide. You can either fix them in a new commit and explain what you did, or just point out the issues in your review. Don't think the reviewers aren’t professional; most appreciate when someone is thorough about their work!
I totally get worried about coming off the wrong way, but asking for clarification isn't rude at all. It's part of the process! Just be direct and respectful.