Help Needed with PowerShell Script for VLANs

Just a quick note, you wrote `Get-VMSWitch` instead of `Get-VMSwitch`. Typos like that can really mess up your script. Double-check for that type of thing throughout your code. Also, instead of using `-eq` and `-ne`, consider error handling with `-ErrorAction`. It makes your script cleaner and more efficient. Lastly, don't forget that you can improve user input by restricting options with `ValidateSet` in your parameters instead of using `Read-Host`. This could help avoid invalid input down the line.

It would be really helpful to clarify what exactly you're trying to achieve with this script. Knowing your intended inputs and expected outputs can guide others to provide more targeted help, minimizing any guesswork.

Have you thought about incorporating parameters in your script instead of constantly using `Read-Host`? This would simplify the input process and ensure users only provide valid values. Using parameters can provide more clarity and allow for better input validation. Just something to consider!

It seems like your if statements might not be set up correctly. For example, this piece of code: ``` if (Get-VMSWitch | where Name -ne "vLanSwitch") { New-VMSwitch -name vLanSwitch -NetAdapterName Ethernet -AllowManagementOs $true } ``` This line will run the `New-VMSwitch` command even if `vLanSwitch` exists. You could change it to check properly for existence like this: ``` if (-not (Get-VMSwitch -Name "vLanSwitch" -ErrorAction SilentlyContinue)) { New-VMSwitch -Name "vLanSwitch" -NetAdapterName "Ethernet" -AllowManagementOS $true } ``` Also, if you're adding VLANs, make sure to validate that the adapter doesn't already exist before adding it. This can prevent duplicates. Here's how you could do that: ``` foreach ($vlan in $vlanList) { $adapterName = "${vmName}$vlan" if (-not (Get-VMNetworkAdapter -ManagementOS -Name $adapterName -ErrorAction SilentlyContinue)) { Add-VMNetworkAdapter -ManagementOS -Name $adapterName -SwitchName "vLanSwitch" Set-VMNetworkAdapterVlan -ManagementOS -VMNetworkAdapterName $adapterName -Access -VlanId $vlan } } ``` This way, you avoid trying to add adapters that already exist!