I'm working at a small IT company where my team lacks any code review process. I've noticed several issues in the code my colleagues have written, which include poor naming conventions, unnecessary code duplications, and some design inefficiencies. Although their coding practices don't currently break anything or slow down the application significantly, I'm concerned about the overall quality. I find it awkward to approach them directly since they're more experienced and have been working here longer. I don't want to come off as overstepping my bounds since I'm not their supervisor, and I'm unsure of the best way to address these issues without causing tension or coming off as rude. Should I even bring this up, or is it better to focus just on my own contributions?
5 Answers
You should definitely bring it up! Frame your feedback in a constructive way without making it about your colleagues specifically. You can suggest adopting some coding standards or guidelines from reputable sources. Ask if everyone can cooperate on improving code quality as a team, which can make everyone feel included rather than singled out, and that creates a more positive coding environment.
I wouldn’t stress too much about directly addressing their code. Instead, lead by example and implement best practices in your work. If you start adopting and demonstrating coding standards like avoiding code duplication, others may follow suit without feeling called out. Additionally, initiating discussions about overall development practices could open up opportunities to talk about code reviews and quality improvements without putting anyone on the defensive.
Your concerns are completely valid! You can approach this by bringing it up with your tech lead or supervisor, focusing on the potential risks that could arise from the current practices. Ask them if they’re aware of these issues, but do it gently—like suggesting a conversation about improving coding standards across the team. This ensures you’re not just pointing fingers but are contributing to better practices. If they’re responsive, they might appreciate you taking the initiative.
It's great that you're wanting to address code quality! One effective way to approach this is by suggesting a regular code review process during your daily standups or retrospectives. You could mention it as a way to collaborate more effectively since 'four eyes are better than two.' This can help create an environment where sharing knowledge and improving code quality becomes a team effort without placing blame.
Yeah, good point, I think this is the best possible solution by far!
Honestly, issues with code quality like this are pretty common in small teams. If you don’t want to take up a crusade against it, just focus on cleaning up the parts of the code you’re responsible for. If you notice something really concerning, it might be worth bringing up casually with your supervisor, but do it in a way that focuses on the product rather than calling out individuals. At the end of the day, all developers are on the same team, and addressing these issues should aim at making your overall product better.
That makes sense! Starting a conversation around general improvements seems way less confrontational.