Hey everyone! I'm curious about how long code reviews typically take in your teams. In my case, we work in two-week sprints, but I often find myself waiting a whole week for feedback on my changes. My merge requests (MRs) are for a new system and can be pretty lengthy—around 300 to 600 lines including tests. This feels extreme to me, especially since our manager has instructed the team to aim for under a week for reviews. Some team members think that 3-4 days is sufficient, while I believe same or next day is more reasonable. I often get strange looks for suggesting quicker reviews. I want to know how others handle this. Am I alone in feeling like waiting too long for reviews is hurting productivity?
5 Answers
In my experience, I stick to a one-hour time limit for reviews, regardless of how big the MR is. It's crucial to keep the workflow smooth, and a week-long wait just drags everything down.
Next day reviews sound great, but with 600 lines on the table, it could be unrealistic. It's all about balancing speed with thoroughness. A careful review can take time, but if that's dragging out the process, it might be worth discussing with the team.
As a team lead, I try to get reviews done within an hour. It's part of the job to ensure that the team keeps moving forward, and if reviews are delayed, it affects our overall velocity.
For my team, we aim for code reviews to be done on the same or next day. We also focus on keeping the change sets small and well-defined, which definitely helps speed things up.
How long it takes really varies by team, but waiting for reviews can cost money and lead to merge conflicts and bugs popping up later. I highly recommend prioritizing immediate reviews, or even skipping them entirely if the code has been reviewed in a pair programming setup.
Related Questions
How To: Running Codex CLI on Windows with Azure OpenAI
Set Wordpress Featured Image Using Javascript
How To Fix PHP Random Being The Same
Why no WebP Support with Wordpress
Replace Wordpress Cron With Linux Cron
Customize Yoast Canonical URL Programmatically