Is Automating Cleanup of 233 useEffect Hooks a Good Move?

I’d recommend starting with the most critical useEffects first instead of trying to fix all 233 at once. Focus on those in key user paths or that are causing performance issues. Honestly, preventing messy useEffect situations in the future is more valuable than just cleaning up old ones. Perhaps establish some linting rules or team guidelines to avoid finding yourself in the same boat in six months. Treat it like technical debt; fix them as you work on related files rather than doing a massive cleanup. By the way, what kinds of issues is the tool pointing out? Missing dependencies, cleanup functions, or something else?

I’m just curious about the purpose of all those useEffects. If you manage your data, business logic, and networking separately from your components and hooks, it becomes much easier to handle. Components are often misused as singular building blocks that lead to complex effect chains.

How good is your testing coverage? It’s a crucial factor to consider when dealing with useEffects.

I followed the official React guidance for removing useEffects, and it turned out many were necessary. If you try setting state during rendering without a useEffect, you risk running into issues like 'Cannot update a component while rendering.' The React docs don’t really address this well, and I didn’t find a good solution either.

Using useEffect isn't inherently bad if you understand its purpose. The idea that 'effects are bad' seems to come from newer developers misusing it for data fetching and other operations. It's all about knowing when and how to use it effectively.

If it’s working, maybe you should just leave it alone. Sometimes, not touching it might be the best choice.

Make sure you create tests before diving into the cleanup. This way, you can ensure that your changes don’t inadvertently break anything.